Reapply "Workflow adjustments" #5301
Merged
+171
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b640a16.
Should fix missing `../../yosys-abc`
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| } | ||
| } | ||
| var.clk_en = find_single_cap(pdef.clken, cram.options, portopts, "clken"); | ||
| var.clk_en = find_single_cap(pdef.clken, cram.options, portopts, "clken") != nullptr; |
Member
There was a problem hiding this comment.
I'm morbidly curious why this change is required 🤔 Is something about how find_single_cap is declared interfering with the implicit conversion to bool?
Member
Author
There was a problem hiding this comment.
The actual fix is assigning a default value to PortVariant::clk_en, this change was incidental while investigating but it made sense to me to leave it in since it helps with readability.
Collaborator
|
|
KrystalDelusion
added a commit
to KrystalDelusion/yosys
that referenced
this pull request
Sep 11, 2025
…_5280" This reverts commit 88eb83a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
#5280 had two failing jobs CI on merge and was reverted.
test-cellsjob was added in Updating test_cell #5024 based on the old reusable build cache name (i.e. including sanitizer). This was merged after Workflow adjustments #5280 was written, but it didn't trigger a merge conflict so I forgot to update the PR to catch that one.run-sanworked fine when it was part of thetest-build.ymlwhere it had separate build and test jobs, with the build job using an out-of-tree build. When I moved it intotest-sanitizers.ymlI merged the build and test jobs, but didn't account for the out-of-tree build.iverilogcache key has been broken since CI: Fixes from zizmor #5016. It was changed to use shell expansion, but it wasn't running in a shell and was instead an action variable.Explain how this is achieved.
test-cells.run-santo build Yosys in-tree.IVERILOG_GITto output instead of env, so we can expand it without worrying about environment variable vulnerabilities.If applicable, please suggest to reviewers how they can test the change.
I tested the two failing jobs on my fork, since
test-sanitizers.ymlno longer exists onmainand therefore github doesn't allow workflow triggers. Compiler testing (test-cells), and run-san.